Fixed compile errors caused by conversion from int to uint16_t
#3395
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahdi Ramezani <[email protected]>
mramezani95
force-pushed
the
mramezani/fix_narrowing_conversion
branch
from
5572391
to
439b172
Compare
prsunny
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed 3 narrowing conversion issues in the code.
Why I did it
g++ 9.4.0 and 10.5.0 both reported compile errors when trying to compile
aclorch.cppusing-Werrorand-Wconversionflags.How I verified it
I compiled the code using g++ 10.5.0 after the changes it was successful.
Details if related